Skip to content

Add support for ReservationGroup to bigqueryreservation#16765

Merged
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
jielin-bq:main
Mar 23, 2026
Merged

Add support for ReservationGroup to bigqueryreservation#16765
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
jielin-bq:main

Conversation

@jielin-bq
Copy link
Contributor

@jielin-bq jielin-bq commented Mar 19, 2026 •
edited
Loading

This is to add support for ReservationGroup to bigqueryreservation by adding a reservation_group as a new resource as well as adding reservation_group as a new property to the existing resource reservation. See b/452350812 for more details.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigqueryreservation: added `reservation_group` field to `reservation` resource

`google_bigqueryreservation_reservation_group`

@jielin-bq
Add new resource ReservationGroup and add reservationGroup as a new p…
27c0768 
…roperty to resource Reservation in bigqueryreservation
@modular-magician
Copy link
Collaborator

modular-magician commented Mar 19, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 728 files changed, 2393 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 806 files changed, 2549 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 105 insertions(+))

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 19, 2026

Tests analytics

Total tests: 5494
Passed tests: 5006
Skipped tests: 483
Affected tests: 5

Click here to see the affected service packages
  • certificatemanager
  • cloudbuild
  • edgenetwork
  • spanner
  • storagebatchoperations
  • deploymentmanager
  • firebasehosting
  • storagetransfer
  • bigqueryconnection
  • bigtable
  • binaryauthorization
  • containerattached
  • redis
  • sourcerepo
  • transcoder
  • cloudrun
  • compute
  • containeranalysis
  • firebaseailogic
  • pubsublite
  • documentai
  • iam2
  • iam3
  • oracledatabase
  • sql
  • storageinsights
  • dataplex
  • cloudrunv2
  • cloudsecuritycompliance
  • databasemigrationservice
  • gkeonprem
  • storage
  • workbench
  • apigateway
  • cloudidentity
  • dialogflow
  • eventarc
  • iambeta
  • saasruntime
  • secretmanagerregional
  • integrationconnectors
  • beyondcorp
  • cloudids
  • colab
  • dns
  • filestore
  • notebooks
  • securitycentermanagement
  • composer
  • edgecontainer
  • firebaseapphosting
  • workstations
  • cloudasset
  • cloudfunctions2
  • cloudquotas
  • gkehub2
  • kms
  • logging
  • memcache
  • ces
  • cloudscheduler
  • networkconnectivityv1
  • backupdr
  • clouddomains
  • hypercomputecluster
  • tags
  • orgpolicy
  • servicedirectory
  • storagecontrol
  • accessapproval
  • datapipeline
  • developerconnect
  • observability
  • osconfigv2
  • billing
  • networkmanagement
  • oslogin
  • parametermanager
  • gkebackup
  • secretmanager
  • serviceusage
  • biglakeiceberg
  • documentaiwarehouse
  • firebase
  • integrations
  • looker
  • monitoring
  • pubsub
  • cloudbuildv2
  • tpuv2
  • contactcenterinsights
  • firebasedataconnect
  • iap
  • vectorsearch
  • gkehub
  • migrationcenter
  • memorystore
  • apihub
  • bigquerydatapolicyv2
  • bigqueryreservation
  • cloudtasks
  • datacatalog
  • essentialcontacts
  • firebaseappcheck
  • apigee
  • artifactregistry
  • bigquery
  • bigquerydatapolicy
  • dataproc
  • modelarmor
  • privateca
  • securityscanner
  • blockchainnodeengine
  • datalossprevention
  • dataprocmetastore
  • firestore
  • mlengine
  • osconfig
  • privilegedaccessmanager
  • securesourcemanager
  • modelarmorglobal
  • accesscontextmanager
  • activedirectory
  • discoveryengine
  • healthcare
  • securitycenter
  • servicenetworking
  • vpcaccess
  • networkconnectivity
  • apphub
  • dataprocgdc
  • datastream
  • firebaseextensions
  • parametermanagerregional
  • resourcemanager
  • biglake
  • dialogflowcx
  • firebasedatabase
  • managedkafka
  • vertexai
  • appengine
  • bigqueryanalyticshub
  • chronicle
  • clouddeploy
  • identityplatform
  • networkservices
  • parallelstore
  • securityposture
  • bigquerydatatransfer
  • corebilling
  • datafusion
  • firebasestorage
  • netapp
  • iamworkforcepool
  • resourcemanager3
  • vmwareengine
  • alloydb
  • dataform
  • gemini
  • networksecurity
  • securitycenterv2
  • siteverification
  • lustre
  • workflows

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryReservationGroup_basic
  • TestAccBigqueryReservationReservationGroup_bigqueryReservationGroupBasicExample
  • TestAccBigqueryReservation_reservationGroup_update
  • TestAccDataformConfig_update
  • TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

@jielin-bq jielin-bq marked this pull request as ready for review March 19, 2026 16:52
@github-actions github-actions bot requested a review from trodge March 19, 2026 16:52
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 19, 2026

🔴 The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR.
View the build log

@jielin-bq
Copy link
Contributor Author

jielin-bq commented Mar 19, 2026

The failed test (TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate) doesn't seem to related the the changes we have here.

@trodge
Copy link
Contributor

trodge commented Mar 20, 2026

/gcbrun

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 729 files changed, 2395 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 807 files changed, 2551 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 105 insertions(+))

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 21, 2026

Tests analytics

Total tests: 5514
Passed tests: 5027
Skipped tests: 484
Affected tests: 3

Click here to see the affected service packages
  • gkehub
  • corebilling
  • dataplex
  • dataprocmetastore
  • accessapproval
  • iam2
  • privateca
  • vectorsearch
  • beyondcorp
  • bigquery
  • dataproc
  • dialogflowcx
  • discoveryengine
  • colab
  • edgenetwork
  • firebaseailogic
  • mlengine
  • observability
  • orgpolicy
  • privilegedaccessmanager
  • siteverification
  • bigquerydatatransfer
  • blockchainnodeengine
  • kms
  • resourcemanager3
  • storagebatchoperations
  • workflows
  • backupdr
  • edgecontainer
  • networksecurity
  • appengine
  • chronicle
  • containerattached
  • firestore
  • logging
  • servicedirectory
  • cloudsecuritycompliance
  • firebaseextensions
  • oracledatabase
  • vmwareengine
  • essentialcontacts
  • integrations
  • notebooks
  • parallelstore
  • tpuv2
  • bigqueryanalyticshub
  • bigqueryconnection
  • dataprocgdc
  • gkebackup
  • identityplatform
  • alloydb
  • bigquerydatapolicy
  • certificatemanager
  • dns
  • eventarc
  • gemini
  • monitoring
  • activedirectory
  • cloudasset
  • clouddeploy
  • clouddomains
  • cloudidentity
  • dataform
  • storagecontrol
  • vertexai
  • cloudscheduler
  • contactcenterinsights
  • integrationconnectors
  • developerconnect
  • firebaseapphosting
  • looker
  • lustre
  • migrationcenter
  • oslogin
  • composer
  • memorystore
  • storageinsights
  • tags
  • datacatalog
  • gkeonprem
  • parametermanagerregional
  • saasruntime
  • securesourcemanager
  • artifactregistry
  • bigquerydatapolicyv2
  • bigtable
  • billing
  • netapp
  • parametermanager
  • sourcerepo
  • storage
  • bigqueryreservation
  • datastream
  • firebasestorage
  • iamworkforcepool
  • managedkafka
  • modelarmor
  • pubsublite
  • resourcemanager
  • datalossprevention
  • cloudrun
  • compute
  • databasemigrationservice
  • hypercomputecluster
  • modelarmorglobal
  • securityposture
  • vpcaccess
  • accesscontextmanager
  • cloudquotas
  • gkehub2
  • servicenetworking
  • transcoder
  • documentai
  • iap
  • networkconnectivityv1
  • workstations
  • apphub
  • binaryauthorization
  • containeranalysis
  • datafusion
  • firebaseappcheck
  • firebasehosting
  • cloudbuildv2
  • firebase
  • iam3
  • networkmanagement
  • secretmanagerregional
  • securitycentermanagement
  • storagetransfer
  • biglakeiceberg
  • documentaiwarehouse
  • memcache
  • networkconnectivity
  • osconfig
  • apigee
  • deploymentmanager
  • iambeta
  • sql
  • workbench
  • cloudrunv2
  • cloudtasks
  • filestore
  • firebasedataconnect
  • healthcare
  • networkservices
  • ces
  • datapipeline
  • dialogflow
  • osconfigv2
  • apihub
  • biglake
  • pubsub
  • secretmanager
  • securitycenter
  • spanner
  • cloudbuild
  • cloudfunctions2
  • firebasedatabase
  • redis
  • securitycenterv2
  • securityscanner
  • serviceusage
  • apigateway
  • cloudids

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_sampleRow
  • TestAccDataformConfig_dataformConfigWithKmsKeyExample
  • TestAccDataformConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 21, 2026

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Debug log]
TestAccDataformConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

@jielin-bq
Copy link
Contributor Author

jielin-bq commented Mar 21, 2026 •
edited
Loading

Two different tests failed for the new run and are not related to the changes here either. Could you please take a look? We are targeting to get this change out to GA by end of March. Thanks!

@jielin-bq
Copy link
Contributor Author

jielin-bq commented Mar 23, 2026

/gcbrun

@trodge trodge added this pull request to the merge queue Mar 23, 2026
Merged via the queue into GoogleCloudPlatform:main with commit f07caeb Mar 23, 2026
25 of 27 checks passed
This was referenced Mar 23, 2026
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trodge trodge trodge approved these changes

Assignees

No one assigned

Labels

service/terraform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jielin-bq @modular-magician @trodge